[FEA] Create ListSeries from JS Arrays, add ListSeries.getValue()
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… libcudf list_scalar
…e test for ListSeries.setValue until cuDF supports scatter for list_scalar
bryevdv
reviewed
May 11, 2021
bryevdv
approved these changes
May 11, 2021
AjayThorve
reviewed
May 11, 2021
| let bigintsCount = 0; | ||
| let booleansCount = 0; | ||
| let unknownCount = 0; | ||
| value.forEach((val) => { |
There was a problem hiding this comment.
Much more efficient, since it only loops over the values once!
There was a problem hiding this comment.
couldn't this just short-circuit and throw immediately in case of an unknown type? Then the logic below could also be slightly simplified (no need to check unknownCount)
There was a problem hiding this comment.
@bryevdv yes I believe it could!
AjayThorve
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
cudf::get_elementsupportslist_scalar, we can addListSeries.getValue().ListSeriesfrom Arrays of JS ArraysgetValueandsetValueto the Series subclasses to make the types happyListSeries.getValue()